Make socket.feathers data available in authentication hooks

[thomas-p-wilson]

In my application I need to pass certain information about the connection/request to hooks on some of my services, including my users service.

https://github.com/feathersjs/feathers-authentication/blob/master/src/socket/handler.js#L58 forbids this by not including the socket.feathers object (if available), thus the only data available to the authentication hooks over socket/primus is that specified on the aforementioned line 58.

Given:

const app = feathers();
app
    .configure(hooks())
    .configure(rest())
    .configure(socketio((io) => {
        io.use((socket, next) => {
            console.log('Socket request');
            socket.feathers.data = 'Hello world';
            next();
        });
    }))
    .configure(authentication());

app.service('authentication').hooks({
    'before': {
        'create': [
            // You can chain multiple strategies
            function(hook) {
                console.log('Hook: ', hook);
            },
            authentication.hooks.authenticate(['jwt', 'local'])
        ],
        'remove': [
            authentication.hooks.authenticate('jwt')
        ]
    }
});

The result of an authentication attempt always results in:

Hook:  { data: 
      { strategy: 'local',
        email: '[email protected]',
        password: 'admin' },
     params: 
      { query: {},
        provider: 'socketio',
        headers: {},
        session: {},
        cookies: {} },
     ...
  }

where the ideal situation would result in:

Hook:  { data: 
      { strategy: 'local',
        email: '[email protected]',
        password: 'admin' },
     params: 
      { query: {},
        provider: 'socketio',
        headers: {},
        session: {},
        cookies: {},
        data: 'Hello world' },
     ...
  }

I have cobbled together a quick fix for my application for the time being. I will clean it up, instrument/test it, and submit a PR to resolve.