Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We shouldn't remove properties from original objects #49

Closed
ekryski opened this issue Jul 7, 2016 · 1 comment
Closed

We shouldn't remove properties from original objects #49

ekryski opened this issue Jul 7, 2016 · 1 comment
Labels
bug

Comments

@ekryski
Copy link
Member

ekryski commented Jul 7, 2016

Originally this came up in the NeDB adapter. But we should not be calling delete on the original object. Instead we should make a copy and then call delete, or only pluck the keys that we want.
@ekryski ekryski added the bug label Jul 7, 2016
@daffl daffl mentioned this issue Jul 8, 2016
Merged
@daffl
Copy link
Member

daffl commented Jul 8, 2016

Closed via #50

@daffl daffl closed this as completed Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daffl @ekryski