feat: Add online/offline replica support #4812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed that one of the operator unit tests was failing from |
tchughesiv
requested changes
Dec 4, 2024
|
@dandawg all of the TLS unit tests should pass, just as they do in master. This is likely due to rebase leftovers. |
dmartinol
reviewed
Dec 5, 2024
|
I addressed the TLS merge conflict. All operator tests passed for me locally. It looks like there is a new image version--I'll make the update. |
dandawg
force-pushed
the
add-replicas
branch
2 times, most recently
from
2acf6c1 to
e727754
Compare
tchughesiv
requested changes
Dec 5, 2024
tchughesiv
requested changes
Dec 5, 2024
tchughesiv
requested changes
Dec 5, 2024
dandawg
force-pushed
the
add-replicas
branch
from
fe5e60c to
bd08e64
Compare
tchughesiv
reviewed
Dec 11, 2024
dandawg
force-pushed
the
add-replicas
branch
from
bd08e64 to
45724cf
Compare
dandawg
force-pushed
the
add-replicas
branch
from
24ce2e7 to
d8b5f55
Compare
tchughesiv
requested changes
Dec 11, 2024
Signed-off-by: dandawg <[email protected]>
dandawg
force-pushed
the
add-replicas
branch
from
d8b5f55 to
8036cef
Compare
tchughesiv
requested changes
Dec 11, 2024
Co-authored-by: Tommy Hughes IV <[email protected]> Signed-off-by: dandawg <[email protected]>
Signed-off-by: dandawg <[email protected]>
Signed-off-by: dandawg <[email protected]>
Signed-off-by: dandawg <[email protected]>
dandawg
force-pushed
the
add-replicas
branch
from
68f0eec to
2f26c94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds offline/online replica scaling support to the FeastServices specs, as well as controller functionality for the feast operator to control replicas. A simple unit test was also added.
Which issue(s) this PR fixes:
Misc