Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sampled scalar value verification failure for 0 value if float is defined #3400

Closed
kysersozelee opened this issue Dec 19, 2022 · 0 comments · Fixed by #3401
Closed

sampled scalar value verification failure for 0 value if float is defined #3400

kysersozelee opened this issue Dec 19, 2022 · 0 comments · Fixed by #3401

Comments

@kysersozelee
Copy link
Contributor

Expected Behavior

Regardless of whether it is 0 or 0.0, conversion for int and float types must be performed.

Current Behavior

It is defined as a float type, but if 0 is set other than 0.0, an assert fail occurs.

Steps to reproduce

If 0 is set in the BigQuery table that owns the float type, it may be recognized as an int when materializing using the feast sdk.

Specifications

  • Version: 0.27.1
  • Platform: regardless
  • Subsystem: regardless

Possible Solution

If the value is set to 0, the assertion is modified so that it is not related to int or float.

@felixwang9817 felixwang9817 changed the title sampled scala value verification failure for 0 value if float is defined sampled scalar value verification failure for 0 value if float is defined Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant