Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added implementations for Duration to chrono #35

Merged
merged 4 commits into from
Apr 13, 2023

Conversation

alexthe2
Copy link
Contributor

Added chrono::Duration <-> pbDuration

@alexthe2
Copy link
Contributor Author

@fdeantoni forgot to tag you

@fdeantoni
Copy link
Owner

Thanks for this PR @alexthe2! The PR generally looks good but I see it also includes .idea files. Are these necessary or can we just make do with the changes in src/pbtime.rs?

@alexthe2
Copy link
Contributor Author

alexthe2 commented Apr 2, 2023

Oh yeah, ofc I guess the .gitignore didn't work correctly, let me fix that

@alexthe2
Copy link
Contributor Author

alexthe2 commented Apr 2, 2023

done ;)

@fdeantoni
Copy link
Owner

Thanks @alexthe2! One thing though, I would rather not include any IDE specific things in the project .gitignore. I think those are better placed in your global gitignore (since you can tailor that one specifically to the IDE you use). I know it's a little pedantic, but I hope it makes sense :) After all, there are many different IDE's out there and the working files/folders they store may change over time...

@alexthe2
Copy link
Contributor Author

sorry, for the long wait I forgot about it. Modified it

@fdeantoni
Copy link
Owner

This is great, many thanks @alexthe2 !

@fdeantoni fdeantoni merged commit df26ebb into fdeantoni:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants