Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

선형과 모듈 개선(#67) #82

Merged
merged 1 commit into from
Sep 5, 2019
Merged

선형과 모듈 개선(#67) #82

merged 1 commit into from
Sep 5, 2019

Conversation

JungYT
Copy link
Contributor

@JungYT JungYT commented Sep 2, 2019

예전엔 함수의 input order가 어느정도 정해져 있어야 했다.(첫 번째 input은 무조건 state여야 했으며 control, external, time등이 오면 셋 중엔 control이 무조건 먼저 와야 했다.)

이젠 function의 input arguments 순서를 자유롭게 만들어도 되며 선형화할 때 function의 몇 번째 argument로 자코비안을 구할 것인지 정해주면 된다.

before
Function which user wants to linearize have to observe the order of
input arguments.
after
The function have not to observe the order of input arguments.
User just determine which numberth of input arguments the function
should be linearized about

before
Function which user wants to linearize have to observe the order of
input arguments.
after
The function have not to observe the order of input arguments.
User just determine which numberth of input arguments the function
should be linearized about
@JungYT JungYT added the enhancement New feature or request label Sep 2, 2019
@JungYT JungYT added this to the Sprint Aug 26 - Aug 30 milestone Sep 2, 2019
@JungYT JungYT self-assigned this Sep 2, 2019
@JungYT JungYT merged commit a04139b into develop Sep 5, 2019
@seong-hun
Copy link
Owner

이거 왜 벌써 머지 돼버렸죠..? 리뷰중이었는데ㅠ

@JinraeKim
Copy link
Contributor

@seong-hun 오랫동안 리뷰가 진행되지 않길래 리뷰중이지 않은 줄 알았다고 합니다

@seong-hun
Copy link
Owner

@JungYT @JinraeKim 헐 이게 코드 코멘트만 달아 놓으면 등록이 안되나보다.. 나 일캐 하고 있었거덩..
image

-``u``: control input (`float` or `int`). arbitraty argumnets
-``e``: external input (`float` or `int`). arbitraty argumnets
funcion : callable
``function`` is what we want to get jacobian function.
i : int or float
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

int or float 대신 int 로 하고 들어오는 인자가 int 인지 체크하는게 나을 것 같습니다.

``i`` means i-th argument of ``function`` and
what will we get Jacobian function for.
for example,
if you want to get Jacobian function of ``function`` for first argument
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이간 좀 사소한데, 각 줄의 길이가 제각각인 것을 조금 일정하게 바꾸는게 좋을 것 같습니다.

@JungYT
Copy link
Contributor Author

JungYT commented Sep 9, 2019

심지어 이건 알림 뜨지도 않았네. 다음 버전에 수정할게

@JinraeKim JinraeKim deleted the feature/iss67 branch September 9, 2019 07:53
@JinraeKim JinraeKim restored the feature/iss67 branch September 9, 2019 07:53
@JinraeKim JinraeKim deleted the feature/iss67 branch September 9, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants