Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: link shoutrrr and initialize services (part 1 of shoutrrr support) #633

Merged
merged 14 commits into from
Nov 6, 2023

Conversation

favonia
Copy link
Owner

@favonia favonia commented Nov 5, 2023

Related: #532 and #632.

  • Modify setter/updater to generate messages
  • Real-life testing

@favonia favonia added this to the 1.12.0 milestone Nov 5, 2023
@favonia favonia added the enhancement New feature or request label Nov 5, 2023
@favonia favonia force-pushed the support-shoutrrr branch 3 times, most recently from cb1a429 to 3c6f32c Compare November 5, 2023 14:05
Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #633 (da0b456) into main (17c7b61) will increase coverage by 0.32%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #633      +/-   ##
==========================================
+ Coverage   88.50%   88.83%   +0.32%     
==========================================
  Files          45       48       +3     
  Lines        2341     2410      +69     
==========================================
+ Hits         2072     2141      +69     
  Misses        259      259              
  Partials       10       10              
Flag Coverage Δ
unittests 88.83% <100.00%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/config/config.go 100.00% <100.00%> (ø)
internal/config/config_print.go 100.00% <100.00%> (ø)
internal/config/config_read.go 100.00% <100.00%> (ø)
internal/config/env_base.go 100.00% <100.00%> (ø)
internal/config/env_notifier.go 100.00% <100.00%> (ø)
internal/monitor/healthchecks.go 86.04% <100.00%> (ø)
internal/monitor/uptimekuma.go 95.69% <100.00%> (ø)
internal/notifier/composite.go 100.00% <100.00%> (ø)
internal/notifier/shoutrrr.go 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Repository owner deleted a comment from sonarcloud bot Nov 5, 2023
@favonia favonia changed the title feat: support shoutrrr feat: support shoutrrr (part 1) Nov 6, 2023
@favonia favonia changed the title feat: support shoutrrr (part 1) feat: support shoutrrr Nov 6, 2023
@favonia favonia changed the title feat: support shoutrrr feat: linking shoutrrr (part 1 of support) Nov 6, 2023
@favonia favonia changed the title feat: linking shoutrrr (part 1 of support) feat: link shoutrrr and initialize services (part 1 of shoutrrr support) Nov 6, 2023
@favonia favonia merged commit 61f42a0 into main Nov 6, 2023
10 checks passed
@favonia favonia deleted the support-shoutrrr branch November 6, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant