cmd: make :GoRun async #3525
Open
cmd: make :GoRun async #3525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make go#cmd#Run execute `go run` asynchronously. This will slightly depart from the previous handling of stderr output. With the :make approach, any output to stderr will populate the quickfix window. When run as a job, though, the output will only be parsed as an error if the program being run exits non-zero. See fatih#3085 (comment) for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make go#cmd#Run execute
go runasynchronously. This will slightly depart from the previous handling of stderr output. With the :make approach, any output to stderr will populate the quickfix window. When run as a job, though, the output will only be parsed as an error if the program being run exits non-zero. See#3085 (comment) for more information.
This is #3086 again. It needs more work before being merged in order to make sure the output is provided to the user to avoid #3523.