Remove the deprecated alecthomas/gometalinter completely

[aofei]

Go has changed the default value of GO111MODULE to "on" last month (golang/go@cf46916). It caused a big problem for this project: the alecthomas/gometalinter couldn't be installed.

You can try this:

$ GO111MODULE=on go install github.com/alecthomas/gometalinter

If nothing unexpected, it will output:

go: finding github.com/alecthomas/gometalinter v3.0.0+incompatible
go: downloading github.com/alecthomas/gometalinter v3.0.0+incompatible
go: extracting github.com/alecthomas/gometalinter v3.0.0+incompatible
go: finding github.com/google/shlex latest
go: finding gopkg.in/alecthomas/kingpin.v3-unstable latest
go: downloading github.com/google/shlex v0.0.0-20181106134648-c34317bd91bf
go: extracting github.com/google/shlex v0.0.0-20181106134648-c34317bd91bf
go: downloading gopkg.in/alecthomas/kingpin.v3-unstable v3.0.0-20180810215634-df19058c872c
go: extracting gopkg.in/alecthomas/kingpin.v3-unstable v3.0.0-20180810215634-df19058c872c
go: finding github.com/alecthomas/units latest
go: downloading github.com/alecthomas/units v0.0.0-20151022065526-2efee857e7cf
go: finding github.com/nicksnyder/go-i18n v1.10.0
go: extracting github.com/alecthomas/units v0.0.0-20151022065526-2efee857e7cf
go: downloading github.com/nicksnyder/go-i18n v1.10.0
go: extracting github.com/nicksnyder/go-i18n v1.10.0
go: finding github.com/pelletier/go-toml v1.2.0
go: downloading github.com/pelletier/go-toml v1.2.0
go: finding gopkg.in/yaml.v2 v2.2.2
go: extracting github.com/pelletier/go-toml v1.2.0
go: downloading gopkg.in/yaml.v2 v2.2.2
go: extracting gopkg.in/yaml.v2 v2.2.2
go: finding gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405
# github.com/alecthomas/gometalinter
go/pkg/mod/github.com/alecthomas/[email protected]+incompatible/main.go:36:94: cannot use loadConfig (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to app.cmdMixin.flagGroup.Flag("config", "Load JSON configuration from file.").Envar("GOMETALINTER_CONFIG").Action
go/pkg/mod/github.com/alecthomas/[email protected]+incompatible/main.go:38:100: cannot use disableAction (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to app.cmdMixin.flagGroup.Flag("disable", "Disable previously enabled linters.").PlaceHolder("LINTER").Short('D').Action
go/pkg/mod/github.com/alecthomas/[email protected]+incompatible/main.go:39:99: cannot use enableAction (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to app.cmdMixin.flagGroup.Flag("enable", "Enable previously disabled linters.").PlaceHolder("LINTER").Short('E').Action
go/pkg/mod/github.com/alecthomas/[email protected]+incompatible/main.go:40:83: cannot use cliLinterOverrides (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to app.cmdMixin.flagGroup.Flag("linter", "Define a linter.").PlaceHolder("NAME:COMMAND:PATTERN").Action
go/pkg/mod/github.com/alecthomas/[email protected]+incompatible/main.go:43:56: cannot use disableAllAction (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to app.cmdMixin.flagGroup.Flag("disable-all", "Disable all linters.").Action
go/pkg/mod/github.com/alecthomas/[email protected]+incompatible/main.go:44:54: cannot use enableAllAction (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to app.cmdMixin.flagGroup.Flag("enable-all", "Enable all linters.").Action
go/pkg/mod/github.com/alecthomas/[email protected]+incompatible/main.go:200:12: cannot use loadDefaultConfig (type func(*kingpin.Application, *kingpin.ParseElement, *kingpin.ParseContext) error) as type kingpin.Action in argument to app.Action

I also noticed that #2182 has been merged. So, when will this project completely remove the deprecated alecthomas/gometalinter?

[bhcleek]

vim-go doesn't support running Go's tip, but this will be handled before Go 1.13 is released. In the meantime, auto is the default value for GO111MODULE; as long as you run :GoUpdateBinaries or :GoInstallBinaries with a directory in $GOPATH as the working directory, gometalinter should install fine.

We do not yet have a timeline for when gometalinter support will be fully removed from vim-go; it will remain for the foreseeable future.