Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signer does not work with \Zend\Mail\Transport\Sendmail #2

Open
vitgije opened this issue Apr 1, 2015 · 1 comment
Open

Signer does not work with \Zend\Mail\Transport\Sendmail #2

vitgije opened this issue Apr 1, 2015 · 1 comment

Comments

@vitgije
Copy link

vitgije commented Apr 1, 2015

If messages are sent with the \Zend\Mail\Transport\Sendmail class, all the \r\n in the fields are replaced with \n on *nix. By the time this class is called, the message is already signed. Replacing the CRLF with LF breaks the signature, because the body is altered.

https://github.com/zendframework/Component_ZendMail/commit/8ed85e366d7fb660f497a62e28e77a24cae61b55#diff-8f01c40475bc8eac96f7c0e891271d05

@fastnloud
Copy link
Owner

Thank you. I've looked into it. However, I do not think that's what's causing the signature to fail. Reading the specs there should only be one CRLF at the end of the body. When normalizing the newlines I did not take that into account.

The bellow fix should take care of that:

a9ea5b6#diff-c344b8e5fab103a6341161a304282092

Can you verify this?
Hopefully this will address the issues you're having signing your mail.

Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants