From ae562b34ea027096459c50c01c1b2e63ecec470a Mon Sep 17 00:00:00 2001 From: Bret Comnes <166301+bcomnes@users.noreply.github.com> Date: Thu, 6 Jul 2023 09:52:14 -0700 Subject: [PATCH 1/3] Dont fail-fast When trying to debug CI errors in the matrix, its really frustrating to have to uncover them randomly one at a time. Can we change this so that all environments run to completion so its easier to find where problems live? --- .github/workflows/plugins-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/plugins-ci.yml b/.github/workflows/plugins-ci.yml index c8e9a52..9364dc3 100644 --- a/.github/workflows/plugins-ci.yml +++ b/.github/workflows/plugins-ci.yml @@ -97,6 +97,7 @@ jobs: permissions: contents: read strategy: + fail-fast: false matrix: node-version: [14, 16, 18, 20] os: [macos-latest, ubuntu-latest, windows-latest] From f2652dc3cc19642a7e0df1cda648825dbac85d55 Mon Sep 17 00:00:00 2001 From: Bret Comnes Date: Thu, 6 Jul 2023 10:16:12 -0700 Subject: [PATCH 2/3] Add fail-fast input consistently across workflows that accept inputs --- .github/workflows/plugins-ci-mongo.yml | 6 ++++++ .github/workflows/plugins-ci-mysql.yml | 6 ++++++ .github/workflows/plugins-ci-postgres.yml | 6 ++++++ .github/workflows/plugins-ci-redis.yml | 6 ++++++ .github/workflows/plugins-ci.yml | 7 ++++++- 5 files changed, 30 insertions(+), 1 deletion(-) diff --git a/.github/workflows/plugins-ci-mongo.yml b/.github/workflows/plugins-ci-mongo.yml index ee06b5a..f7fdc3b 100644 --- a/.github/workflows/plugins-ci-mongo.yml +++ b/.github/workflows/plugins-ci-mongo.yml @@ -23,6 +23,11 @@ on: required: false default: false type: boolean + fail-fast: + description: 'Set the fail-fast strategey setting.' + required: false + default: true + type: boolean jobs: dependency-review: @@ -97,6 +102,7 @@ jobs: permissions: contents: read strategy: + fail-fast: ${{ inputs.fail-fast }} matrix: node-version: [14, 16, 18, 20] os: [ubuntu-latest] diff --git a/.github/workflows/plugins-ci-mysql.yml b/.github/workflows/plugins-ci-mysql.yml index 8288b42..e06293c 100644 --- a/.github/workflows/plugins-ci-mysql.yml +++ b/.github/workflows/plugins-ci-mysql.yml @@ -23,6 +23,11 @@ on: required: false default: false type: boolean + fail-fast: + description: 'Set the fail-fast strategey setting.' + required: false + default: true + type: boolean jobs: dependency-review: @@ -99,6 +104,7 @@ jobs: permissions: contents: read strategy: + fail-fast: ${{ inputs.fail-fast }} matrix: node-version: [14, 16, 18, 20] os: [ubuntu-latest] diff --git a/.github/workflows/plugins-ci-postgres.yml b/.github/workflows/plugins-ci-postgres.yml index b7e4efd..86d82d6 100644 --- a/.github/workflows/plugins-ci-postgres.yml +++ b/.github/workflows/plugins-ci-postgres.yml @@ -23,6 +23,11 @@ on: required: false default: false type: boolean + fail-fast: + description: 'Set the fail-fast strategey setting.' + required: false + default: true + type: boolean jobs: dependency-review: @@ -97,6 +102,7 @@ jobs: permissions: contents: read strategy: + fail-fast: ${{ inputs.fail-fast }} matrix: node-version: [14, 16, 18, 20] os: [ubuntu-latest] diff --git a/.github/workflows/plugins-ci-redis.yml b/.github/workflows/plugins-ci-redis.yml index b73966b..b9828f8 100644 --- a/.github/workflows/plugins-ci-redis.yml +++ b/.github/workflows/plugins-ci-redis.yml @@ -23,6 +23,11 @@ on: required: false default: false type: boolean + fail-fast: + description: 'Set the fail-fast strategey setting.' + required: false + default: true + type: boolean jobs: dependency-review: @@ -95,6 +100,7 @@ jobs: name: Node.js ${{ matrix.node-version }} - ${{ matrix.db }} runs-on: ubuntu-latest strategy: + fail-fast: ${{ inputs.fail-fast }} matrix: node-version: [14, 16, 18, 20] db: [5, 6, 7] diff --git a/.github/workflows/plugins-ci.yml b/.github/workflows/plugins-ci.yml index 9364dc3..b9cc538 100644 --- a/.github/workflows/plugins-ci.yml +++ b/.github/workflows/plugins-ci.yml @@ -23,6 +23,11 @@ on: required: false default: false type: boolean + fail-fast: + description: 'Set the fail-fast strategey setting.' + required: false + default: true + type: boolean jobs: dependency-review: @@ -97,7 +102,7 @@ jobs: permissions: contents: read strategy: - fail-fast: false + fail-fast: ${{ inputs.fail-fast }} matrix: node-version: [14, 16, 18, 20] os: [macos-latest, ubuntu-latest, windows-latest] From 267efd7656656a9c4e806d8c7f9e95757061865c Mon Sep 17 00:00:00 2001 From: Bret Comnes Date: Thu, 6 Jul 2023 11:32:55 -0700 Subject: [PATCH 3/3] README, spelling, alphabetize --- .github/workflows/plugins-ci-mongo.yml | 16 ++++++++-------- .github/workflows/plugins-ci-mysql.yml | 14 +++++++------- .github/workflows/plugins-ci-postgres.yml | 14 +++++++------- .github/workflows/plugins-ci-redis.yml | 16 ++++++++-------- .github/workflows/plugins-ci.yml | 14 +++++++------- README.md | 1 + 6 files changed, 38 insertions(+), 37 deletions(-) diff --git a/.github/workflows/plugins-ci-mongo.yml b/.github/workflows/plugins-ci-mongo.yml index f7fdc3b..f413a34 100644 --- a/.github/workflows/plugins-ci-mongo.yml +++ b/.github/workflows/plugins-ci-mongo.yml @@ -4,17 +4,22 @@ on: workflow_call: inputs: auto-merge-exclude: - description: 'A semicolon seperated list of packages that you do not want to be auto-merged.' + description: 'A semicolon separated list of packages that you do not want to be auto-merged.' required: false default: 'fastify' type: string + fail-fast: + description: 'Set to false to disable the fail-fast strategy.' + required: false + default: true + type: boolean license-check: - description: 'Check licenses' + description: 'Check licenses.' required: false type: boolean default: false license-check-allowed-additional: - description: 'A semicolon seperated list of additional licenses to allow.' + description: 'A semicolon separated list of additional licenses to allow.' required: false type: string default: '' @@ -23,11 +28,6 @@ on: required: false default: false type: boolean - fail-fast: - description: 'Set the fail-fast strategey setting.' - required: false - default: true - type: boolean jobs: dependency-review: diff --git a/.github/workflows/plugins-ci-mysql.yml b/.github/workflows/plugins-ci-mysql.yml index e06293c..ed8600d 100644 --- a/.github/workflows/plugins-ci-mysql.yml +++ b/.github/workflows/plugins-ci-mysql.yml @@ -4,17 +4,22 @@ on: workflow_call: inputs: auto-merge-exclude: - description: 'A semicolon seperated list of packages that you do not want to be auto-merged.' + description: 'A semicolon separated list of packages that you do not want to be auto-merged.' required: false default: 'fastify' type: string + fail-fast: + description: 'Set to false to disable the fail-fast strategy.' + required: false + default: true + type: boolean license-check: description: 'Check licenses.' required: false type: boolean default: false license-check-allowed-additional: - description: 'A semicolon seperated list of additional licenses to allow.' + description: 'A semicolon separated list of additional licenses to allow.' required: false type: string default: '' @@ -23,11 +28,6 @@ on: required: false default: false type: boolean - fail-fast: - description: 'Set the fail-fast strategey setting.' - required: false - default: true - type: boolean jobs: dependency-review: diff --git a/.github/workflows/plugins-ci-postgres.yml b/.github/workflows/plugins-ci-postgres.yml index 86d82d6..e5d8753 100644 --- a/.github/workflows/plugins-ci-postgres.yml +++ b/.github/workflows/plugins-ci-postgres.yml @@ -4,17 +4,22 @@ on: workflow_call: inputs: auto-merge-exclude: - description: 'A semicolon seperated list of packages that you do not want to be auto-merged.' + description: 'A semicolon separated list of packages that you do not want to be auto-merged.' required: false default: 'fastify' type: string + fail-fast: + description: 'Set to false to disable the fail-fast strategy.' + required: false + default: true + type: boolean license-check: description: 'Check licenses.' required: false type: boolean default: false license-check-allowed-additional: - description: 'A semicolon seperated list of additional licenses to allow.' + description: 'A semicolon separated list of additional licenses to allow.' required: false type: string default: '' @@ -23,11 +28,6 @@ on: required: false default: false type: boolean - fail-fast: - description: 'Set the fail-fast strategey setting.' - required: false - default: true - type: boolean jobs: dependency-review: diff --git a/.github/workflows/plugins-ci-redis.yml b/.github/workflows/plugins-ci-redis.yml index b9828f8..477490f 100644 --- a/.github/workflows/plugins-ci-redis.yml +++ b/.github/workflows/plugins-ci-redis.yml @@ -4,17 +4,22 @@ on: workflow_call: inputs: auto-merge-exclude: - description: 'A semicolon seperated list of packages that you do not want to be auto-merged.' + description: 'A semicolon separated list of packages that you do not want to be auto-merged.' required: false default: 'fastify' type: string + fail-fast: + description: 'Set to false to disable the fail-fast strategy.' + required: false + default: true + type: boolean license-check: - description: 'Check licenses' + description: 'Check licenses.' required: false type: boolean default: false license-check-allowed-additional: - description: 'A semicolon seperated list of additional licenses to allow.' + description: 'A semicolon separated list of additional licenses to allow.' required: false type: string default: '' @@ -23,11 +28,6 @@ on: required: false default: false type: boolean - fail-fast: - description: 'Set the fail-fast strategey setting.' - required: false - default: true - type: boolean jobs: dependency-review: diff --git a/.github/workflows/plugins-ci.yml b/.github/workflows/plugins-ci.yml index b9cc538..d336bf8 100644 --- a/.github/workflows/plugins-ci.yml +++ b/.github/workflows/plugins-ci.yml @@ -4,17 +4,22 @@ on: workflow_call: inputs: auto-merge-exclude: - description: 'A semicolon seperated list of packages that you do not want to be auto-merged.' + description: 'A semicolon separated list of packages that you do not want to be auto-merged.' required: false default: 'fastify' type: string + fail-fast: + description: 'Set to false to disable the fail-fast strategy.' + required: false + default: true + type: boolean license-check: description: 'Check licenses.' required: false type: boolean default: false license-check-allowed-additional: - description: 'A semicolon seperated list of additional licenses to allow.' + description: 'A semicolon separated list of additional licenses to allow.' required: false type: string default: '' @@ -23,11 +28,6 @@ on: required: false default: false type: boolean - fail-fast: - description: 'Set the fail-fast strategey setting.' - required: false - default: true - type: boolean jobs: dependency-review: diff --git a/README.md b/README.md index 10425e1..37210a6 100644 --- a/README.md +++ b/README.md @@ -63,6 +63,7 @@ jobs: | Input Name | Required | Type | Default | Description | | ---------------------------------- | ---------- | ------- | --------- | ---------------------------------------------------------------------------------- | | `auto-merge-exclude` | false | string | `fastify` | Provide a semicolon separated list of packages that you do not want to be auto-merged. | +| `fail-fast` | false | boolean | `true` | Set to `false` to disable the fail-fast strategy. | | `license-check` | false | boolean | `false` | Set to `true` to check that a repository's production dependencies use permissive licenses: 0BSD, Apache-2.0, BSD-2-Clause, BSD-3-Clause, MIT, or ISC. | | `license-check-allowed-additional` | false | string | | Provide a semicolon separated list of SPDX-license identifiers that you want to additionally allow. | | `lint` | false | boolean | `false` | Set to `true` to run the `lint` script in a repository's `package.json`. |