Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different targets for development and production dependencies #443

Closed
2 tasks done
nicolasrouanne opened this issue Jun 21, 2023 · 3 comments · Fixed by #572
Closed
2 tasks done

Different targets for development and production dependencies #443

nicolasrouanne opened this issue Jun 21, 2023 · 3 comments · Fixed by #572

Comments

@nicolasrouanne
Copy link

nicolasrouanne commented Jun 21, 2023

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal

It would be nice if we could configure different rules for development and production dependencies. Something such as

- uses: fastify/github-action-merge-dependabot@v3
   with:
     target:
       production: patch
       development: any

Motivation

I tend to separate devDependencies (e.g. prettier, eslint, etc.) from dependencies. Same applies in ruby for instance.
I like to merge everything that doesn't impact production as soon as it becomes available; however I'm more careful regarding packages that can impact our production app... I don't have enough coverage to be 100% sure.

Example

Here is the syntax from ahmadnassri/action-dependabot-auto-merge which is nice IMO

- match:
    dependency_name: aws-sdk
    update_type: semver:minor

- match:
    dependency_type: development
    update_type: semver:minor # includes patch updates!

- match:
    dependency_type: production
    update_type: security:minor # includes patch updates!

- match:
    dependency_type: production
    update_type: semver:patch
@MDG-MAugier
Copy link

Came to write the same thing +1

@simoneb
Copy link
Collaborator

simoneb commented Feb 7, 2024

The feature request is valid, but the syntax you're proposing is not valid for action inputs, in fact the action you're referring to uses an external configuration file to achieve it.

What I propose is that we introduce two more specific inputs for the action, one called target-development and the other called target-production which, if provided, override the default value provided in the target input (if any).

Copy link

github-actions bot commented Feb 8, 2024

🎉 This issue has been resolved in version 3.10.0 🎉

The release is available on:

Your optic bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants