Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

100% code coverage #258

Closed
mcollina opened this issue Jun 16, 2020 · 5 comments · Fixed by #267
Closed

100% code coverage #258

mcollina opened this issue Jun 16, 2020 · 5 comments · Fixed by #267
Labels
good first issue Good for newcomers

Comments

@mcollina
Copy link
Member

As titled!
@mcollina mcollina added the good first issue Good for newcomers label Jun 16, 2020
@ghost
Copy link

ghost commented Jul 1, 2020

Hey @mcollina

I would like to try this one if you don't mind. Are there any pitfalls or something else I should know about?

@mcollina
Copy link
Member Author

mcollina commented Jul 1, 2020

Not that I know of! Go for it!

@ghost
Copy link

ghost commented Jul 12, 2020

@mcollina

See #267

I've done a bit of a job, though I need a review and, probably, some help from you or another team member

@ghost ghost mentioned this issue Jul 14, 2020
Merged
3 tasks
@zekth zekth reopened this Feb 2, 2021
@zekth
Copy link
Member

zekth commented Feb 2, 2021

Reopening since the coverage has dropped with: #333
and the ci has coveralls landed in : https://github.com/fastify/fastify-swagger/pull/348/files

@climba03003
Copy link
Member

climba03003 commented Feb 5, 2021 •
edited
Loading

Closing as it is bug from the script below

tap --100 test/**/*.js

Missing quote for ** will use the shell evaluation of files, and some of the system may not handle globstar as default (e.g. coveralls). As a result, the coverage result drops.
Fixed in #351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

increase code coverage to 100%
3 participants
@mcollina @zekth @climba03003