Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove default plugin level bodyLimit #18

Merged
merged 1 commit into from
Jul 19, 2018
Merged

remove default plugin level bodyLimit #18

merged 1 commit into from
Jul 19, 2018

Conversation

vincent178
Copy link
Contributor

remove plugin level bodyLimit, because fastify handle bodyLimit centrally. This will cause the plugin don't respect the fasify global bodyLimit.

@vincent178 vincent178 mentioned this pull request Jul 19, 2018
Closed
delvedor
delvedor approved these changes Jul 19, 2018
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina approved these changes Jul 19, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit d5f249c into fastify:master Jul 19, 2018
@vincent178
Copy link
Contributor Author

@mcollina @delvedor would it be possible to pump a small version for fastify-formbody?

@mcollina
Copy link
Member

released.

@vincent178
Copy link
Contributor Author

Thank you @mcollina

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvedor delvedor delvedor approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vincent178 @mcollina @delvedor