We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I'm merging master in next, and the alpha-2 showed this issue
alpha-2
This script:
const avvio = require('.')() avvio.ready().then(() => { console.log('ready') }) // avvio.ready(() => { // console.log('ready') // }) avvio.on('start', () => { console.log('start') })
Produce:
Because of the change, this test is failing: https://github.com/fastify/fastify/blob/9b533f5062356e27d997eeee076375deba37cb69/test/decorator.test.js#L712
Because the fastify's server is flaged as started in the start event here: https://github.com/fastify/fastify/blob/9b533f5062356e27d997eeee076375deba37cb69/fastify.js#L287
started
start
I think ready->start is correct execution order, but if I think in all my application's tests, await server.ready() is quite the standard 😭
ready->start
await server.ready()
The text was updated successfully, but these errors were encountered:
I would say that "start then ready" is definitely incorrect and not the intention. I'm happy to fix it in avvio master.
master
Overall, the implementation of that behavior is wrong :/. I would recommend to fix it in master as well.
Sorry, something went wrong.
No branches or pull requests
I'm merging master in next, and the
alpha-2
showed this issueThis script:
Produce:
Because of the change, this test is failing:
https://github.com/fastify/fastify/blob/9b533f5062356e27d997eeee076375deba37cb69/test/decorator.test.js#L712
Because the fastify's server is flaged as
started
in thestart
event here:https://github.com/fastify/fastify/blob/9b533f5062356e27d997eeee076375deba37cb69/fastify.js#L287
I think
ready->start
is correct execution order, but if I think in all my application's tests,await server.ready()
is quite the standard 😭The text was updated successfully, but these errors were encountered: