Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid JSON.stringify calls #24

Closed
Eomm opened this issue Jul 18, 2021 · 1 comment
Closed

Avoid JSON.stringify calls #24

Eomm opened this issue Jul 18, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Eomm
Copy link
Member

Eomm commented Jul 18, 2021

Yes, it is so right now.

I would open an issue for it and leave it as-is right now

The solutions I see:

  • track the ajv options to write a fast-json-stringify function that serialize them instead of JSON.stringify
  • apply a new logic like:
    • check the number of keys
    • check iteratively the values (I see only primitive types as values)

Originally posted by @Eomm in #1 (comment)
@Eomm Eomm added enhancement New feature or request good first issue Good for newcomers labels Jul 18, 2021
@Eomm
Copy link
Member Author

Eomm commented Nov 7, 2021

closing as duplicate
#2

@Eomm Eomm closed this as completed Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Eomm