Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String search improvements #691

Open
dg-pb opened this issue Jul 26, 2024 · 2 comments
Open

String search improvements #691

dg-pb opened this issue Jul 26, 2024 · 2 comments

Comments

@dg-pb
Copy link

dg-pb commented Jul 26, 2024

I have done some work on fastsearch.h module.

python/cpython#120025

PR was reviewed by few non-core-dev members and was subject to sufficient amount of iterations so that it is currently in stable state.

I have posted in coredev discourse, but without much luck.

So I thought maybe this is a better place to get some attention given that this is largely related to performance.

Apart from performance improvements, it does introduce consistency and simplifications that are helpful to move forward with further improvements (see String Search Overview, Coverage and API).

@markshannon
Copy link
Member

It looks a worthwhile improvement, but I don't think anyone in our team is an expert enough in string searching algorithms to review it.

Trying pinging discourse again?

@iritkatriel
Copy link
Collaborator

CC @gsbrodal (an expert on string algorithms).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants