Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Improve UI for fastapi dev and fastapi run #95

Merged
merged 9 commits into from
Dec 4, 2024

Conversation

patrick91
Copy link
Contributor

@patrick91 patrick91 commented Sep 23, 2024

This PR adds rich-toolkit to improve the look and feel of the app, for now we are only updating the server commands 😊

In terms of the code, I've most of the output out from the discover file into the main cli file (better to keep those utils simpler without any output)

CleanShot 2024-09-23 at 08 06 49@2x

Some potential improvements:

  • Better errors
  • Different colors for different log levels

@patrick91 patrick91 added the feature New feature or request label Sep 23, 2024
@patrick91 patrick91 force-pushed the os/feature/new-dev-mode branch from fb96fd6 to bf2c972 Compare September 23, 2024 14:40
@patrick91
Copy link
Contributor Author

patrick91 commented Sep 23, 2024

There's a small issue when pressing CTRL+C:

CleanShot 2024-09-23 at 17 22 48@2x

you can see ^C (this is sent by the terminal), I have some ideas on how to workaround this, but I don't think it is worth doing it in this PR (if worth doing it at all)

Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! This looks great, and the code much cleaner! πŸš€

Ready the chicken 😎 πŸš€

@tiangolo tiangolo merged commit 6bdcfbf into fastapi:main Dec 4, 2024
14 checks passed
@patrick91 patrick91 deleted the os/feature/new-dev-mode branch December 4, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants