Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_callbacks should use an object instead of an array #170

Closed
humaidk2 opened this issue May 16, 2021 · 1 comment · Fixed by #172
Closed

_callbacks should use an object instead of an array #170

humaidk2 opened this issue May 16, 2021 · 1 comment · Fixed by #172

Comments

@humaidk2
Copy link
Contributor

Hi,

i noticed _callbacks in smpp.js is using an array to store sessions, but deleting elements in an array causes null spaces
I suggest moving it to an object or using .filter or .splice to remove elements from the array

node-smpp/lib/smpp.js

Line 17 in fe53dcc

this._callbacks = [];

@juliangut
Copy link
Collaborator

Hello @humaidk2

PRs are always welcome, if you find the time to create one would be awesome

@humaidk2 humaidk2 mentioned this issue May 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move _callbacks to an object to avoid empty slots humaidk2/node-smpp
2 participants
@juliangut @humaidk2