Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pino for logging #162

Closed
varunsrin opened this issue Oct 11, 2022 · 0 comments · Fixed by #169
Closed

chore: add pino for logging #162

varunsrin opened this issue Oct 11, 2022 · 0 comments · Fixed by #169
Assignees
Milestone

Comments

@varunsrin
Copy link
Member

What is the feature you would like to implement?

Replace console.log with a logger that is performant, can log structured json data and has support for async transports to process and write logs.

Why is this feature important?

Without structured data, logs become very difficult to read in production consoles and make debugging issues much harder. It's important to have this before we deploy hubs to AWS.

Will the protocol spec need to be updated??

No

How should this feature be built? (optional)

  • Add pino and replace all existing instances of console.log.
  • Also add an eslint rule to prevent checking in code with console.log going forward.

Additional context

https://github.com/pinojs/pino/blob/master/docs/benchmarks.md
goldbergyoni/nodebestpractices#684

@varunsrin varunsrin added this to the v2.0.0 p2 milestone Oct 11, 2022
@varunsrin varunsrin self-assigned this Oct 11, 2022
@varunsrin varunsrin linked a pull request Oct 27, 2022 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant