Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slideshow does not wait for video #246

Open
ron4mac opened this issue Feb 19, 2022 · 3 comments
Open

Slideshow does not wait for video #246

ron4mac opened this issue Feb 19, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@ron4mac
Copy link

ron4mac commented Feb 19, 2022

When running the slideshow, items such as video or audio are not allowed to complete before advancing the slideshow.
Note: worked okay in version 3 but version 3 has a bug that it advances the slide for video even when not in slideshow mode.
Also note as well: video slide does not advance when using keyboard arrows(solved by using autoFocus=false)

@sjd23
Copy link

sjd23 commented Jun 21, 2024

I'll add this note here since the other issue was closed:

I found this comment where it was stated that this is not a problem anymore, and the old jsfiddle provided seems to support that idea. This is not the case with 5.0. Is this because a bug was introduced that incidentally removed the support OR was it an intentional feature removal/omission in the later releases?

"Hi,

Slideshow now waits for html5 video to end (starting from v3.4.1)"

(from: fancyapps/fancybox#1983 (comment))

@fancyapps
Copy link
Owner

fancyapps commented Jun 21, 2024

@sjd23 If you have not noticed, this is a completely different project. Fancyapps UI is the successor of the Fancybox project, it was written from scratch and has already been rewritten a couple of times and is now in development for the next major version.

@sjd23
Copy link

sjd23 commented Jun 21, 2024

@fancyapps Of course. I didn't read through the commit history but assumed it was initially ported here as the readme of that repository provides this detail:

"This repository has been archived and is now part of https://github.com/fancyapps/ui"

The feature being gone makes sense to me now though. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants