From 20d61bef71d11c0996397b27b76b6706147d83c7 Mon Sep 17 00:00:00 2001
From: Jason Dellaluce <jasondellaluce@gmail.com>
Date: Mon, 5 Jun 2023 16:54:20 +0000
Subject: [PATCH] fix(userspace/libsinsp): break cases in plugin table type
 switch

Co-authored-by: Lorenzo Susini <susinilorenzo1@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
---
 userspace/libsinsp/plugin_table_api.cpp | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/userspace/libsinsp/plugin_table_api.cpp b/userspace/libsinsp/plugin_table_api.cpp
index 3d4cb27754..912f4a55bc 100755
--- a/userspace/libsinsp/plugin_table_api.cpp
+++ b/userspace/libsinsp/plugin_table_api.cpp
@@ -29,25 +29,25 @@ limitations under the License.
 	switch (_kt) \
 	{ \
 		case ss_plugin_state_type::SS_PLUGIN_ST_INT8: \
-			_X(int8_t, s8) \
+			_X(int8_t, s8); break; \
 		case ss_plugin_state_type::SS_PLUGIN_ST_INT16: \
-			_X(int16_t, s16) \
+			_X(int16_t, s16); break; \
 		case ss_plugin_state_type::SS_PLUGIN_ST_INT32: \
-			_X(int32_t, s32) \
+			_X(int32_t, s32); break; \
 		case ss_plugin_state_type::SS_PLUGIN_ST_INT64: \
-			_X(int64_t, s64) \
+			_X(int64_t, s64); break; \
 		case ss_plugin_state_type::SS_PLUGIN_ST_UINT8: \
-			_X(uint8_t, u8) \
+			_X(uint8_t, u8); break; \
 		case ss_plugin_state_type::SS_PLUGIN_ST_UINT16: \
-			_X(uint16_t, u16) \
+			_X(uint16_t, u16); break; \
 		case ss_plugin_state_type::SS_PLUGIN_ST_UINT32: \
-			_X(uint32_t, u32) \
+			_X(uint32_t, u32); break; \
 		case ss_plugin_state_type::SS_PLUGIN_ST_UINT64: \
-			_X(uint64_t, u64) \
+			_X(uint64_t, u64); break; \
 		case ss_plugin_state_type::SS_PLUGIN_ST_STRING: \
-			_X(std::string, str) \
+			_X(std::string, str); break; \
 		case ss_plugin_state_type::SS_PLUGIN_ST_BOOL: \
-			_X(bool, b) \
+			_X(bool, b); break; \
 		default: \
 			throw sinsp_exception("can't convert plugin state type to typeinfo: " + std::to_string(_kt)); \
 	} \
@@ -441,6 +441,7 @@ struct sinsp_table_wrapper
 			{ \
 				return static_cast<ss_plugin_table_entry_t*>(ret.get()); \
 			} \
+			return NULL; \
 		}
 		__CATCH_ERR_MSG(t->m_owner_plugin->m_last_owner_err, {
 			__PLUGIN_STATETYPE_SWITCH(t->m_key_type);
@@ -554,6 +555,7 @@ struct sinsp_table_wrapper
 		{ \
 			auto e = static_cast<libsinsp::state::table_entry*>(_e); \
 			auto ptr = std::unique_ptr<libsinsp::state::table_entry>(e); \
+			break; \
 		}
 		__CATCH_ERR_MSG(t->m_owner_plugin->m_last_owner_err, {
 			__PLUGIN_STATETYPE_SWITCH(t->m_key_type);