Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate falcon.api_helpers #1903

Closed
vytas7 opened this issue Apr 6, 2021 · 2 comments · Fixed by #1946
Closed

Deprecate falcon.api_helpers #1903

vytas7 opened this issue Apr 6, 2021 · 2 comments · Fixed by #1946
Assignees
@CaselIT
Labels
maintenance
Milestone
Version 3.1

Comments

@vytas7
Copy link
Member

vytas7 commented Apr 6, 2021

See #1902.

Starting with 3.1, mark falcon.api_helpers as deprecated. We could employ module-level __getattr__ or redecorate re-imported functions.
@vytas7 vytas7 added this to the Version 3.1 milestone Apr 6, 2021
@CaselIT
Copy link
Member

CaselIT commented Jun 28, 2021

I think 3.1 is already open, so this can be done right?

@CaselIT CaselIT self-assigned this Jun 28, 2021
@vytas7
Copy link
Member Author

vytas7 commented Jun 28, 2021

Yup, I think so.

Even if we decide to do 3.0.2, we could ship that in a separate bugfix branch.

@CaselIT CaselIT mentioned this issue Aug 6, 2021
Merged
@bkcsfi bkcsfi mentioned this issue Sep 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CaselIT CaselIT

Labels
maintenance
Projects
None yet
Milestone
Version 3.1
Development

Successfully merging a pull request may close this issue.

chore: re-enable api_helpers deprecation CaselIT/falcon
2 participants
@vytas7 @CaselIT