Add Faker::Games::Touhou #2197
Merged
Add Faker::Games::Touhou #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psibi
requested changes
Nov 22, 2020
|
Made some corrections to the .yml to remove duplicate cards and some double quotation marks and apostrophes. |
psibi
approved these changes
Nov 23, 2020
|
@dysnomian Thanks, the changes looks good. But I'm slightly worried that the tests are failing in the CI now. It seems to be unrelated with this MR, but for master branch the test seems to be passing. |
psibi
reviewed
Nov 25, 2020
There was a problem hiding this comment.
LGTM. One more change: Can you add the new module entry in the README: https://github.com/faker-ruby/faker#default ?
|
Thanks! |
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No-StoryDescription:
Adds
Faker::Games::Touhougenerators.