-
-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(locale): implement state info on sk locale #3054
Conversation
✅ Deploy Preview for fakerjs canceled.
|
@boubkerbribri you need to adjust the test in faker/test/all-functional.spec.ts Line 53 in bb1a73c
Additionally, you should run the |
39ba27f
to
bf818bf
Compare
Should be all good now, thanks |
bf818bf
to
582a3ea
Compare
582a3ea
to
19c698d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3054 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 2772 2772
Lines 226173 226182 +9
Branches 945 939 -6
=======================================
+ Hits 226102 226111 +9
Misses 71 71
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Issue Number
#3052
Changes Made