Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(locale)!: remove deprecated locale aliases #2787

Merged
merged 3 commits into from
Apr 7, 2024
Merged

refactor(locale)!: remove deprecated locale aliases #2787

merged 3 commits into from
Apr 7, 2024

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release labels Apr 5, 2024
@Shinigami92 Shinigami92 added this to the v9.0 milestone Apr 5, 2024
@Shinigami92 Shinigami92 self-assigned this Apr 5, 2024
@Shinigami92 Shinigami92 requested a review from a team as a code owner April 5, 2024 06:14
@netlify Netlify
Copy link

netlify bot commented Apr 5, 2024 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 25a822c
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6612c28c772551000849c39f
😎 Deploy Preview https://deploy-preview-2787.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Apr 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (501f4b3) to head (25a822c).

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2787   +/-   ##
=======================================
  Coverage   99.94%   99.95%           
=======================================
  Files        2975     2972    -3     
  Lines      212600   212564   -36     
  Branches      950      947    -3     
=======================================
- Hits       212477   212458   -19     
+ Misses        119      106   -13     
+ Partials        4        0    -4

see 3 files with indirect coverage changes

@Shinigami92 Shinigami92 requested a review from a team April 5, 2024 06:18
ST-DDT
ST-DDT reviewed Apr 5, 2024
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a migration guide?

@Shinigami92
Copy link
Member Author

Does this need a migration guide?

thx for the reminder, totally forgot that we have such thing in this repo

@ST-DDT ST-DDT requested a review from a team April 5, 2024 06:55
@ST-DDT ST-DDT enabled auto-merge (squash) April 7, 2024 15:58
@ST-DDT ST-DDT merged commit 03ac471 into next Apr 7, 2024
20 checks passed
@ST-DDT ST-DDT deleted the refactor-remove-deprecated-locale-aliases branch April 7, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Shinigami92 @ST-DDT @xDivisionByZerox