-
-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra(eslint): prefer-exponentiation-operator #2585
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
p: 1-normal
Nothing urgent
c: infra
Changes to our infrastructure or project setup
labels
Dec 20, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2585 +/- ##
==========================================
- Coverage 99.58% 99.57% -0.01%
==========================================
Files 2806 2806
Lines 250195 250195
Branches 1109 1105 -4
==========================================
- Hits 249145 249131 -14
- Misses 1022 1036 +14
Partials 28 28 |
matthewmayer
approved these changes
Dec 20, 2023
This is an addition to the recommended unicorn preset? |
This is an addition to eslint's recommended rule set, not unicorn's. |
xDivisionByZerox
approved these changes
Dec 20, 2023
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the
prefer-exponentiation-operator
lint rule.Currently there are 6 places that use
x ** y
and zero places that useMath.pow(x, y)
.Enabling this rule should keep the code consistent in the future.