-
-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(locale): Add Street to location fr_SN #2536
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…faker into add-locale-senegal
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2536 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 2801 2806 +5
Lines 249910 249971 +61
Branches 1083 1084 +1
=======================================
+ Hits 248863 248932 +69
+ Misses 1019 1011 -8
Partials 28 28
|
ST-DDT
added
s: on hold
Blocked by something or frozen to avoid conflicts
p: 1-normal
Nothing urgent
c: locale
Permutes locale definitions
m: location
Something is referring to the location module
labels
Nov 10, 2023
Blocked by #2533 |
ST-DDT
added
needs rebase
There is a merge conflict
and removed
s: on hold
Blocked by something or frozen to avoid conflicts
labels
Nov 11, 2023
This is no longer blocked, but there appears to be a merge conflict. |
Sorry, I think I've solved it. |
matthewmayer
approved these changes
Nov 11, 2023
ST-DDT
reviewed
Nov 12, 2023
ST-DDT
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: locale
Permutes locale definitions
m: location
Something is referring to the location module
p: 1-normal
Nothing urgent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the most famous streets in the Dakar and Thiès region. As it's an exhaustive list, I've only included a few, although others may be added in future PRs.
https://senegal-streets.openalfa.com/dakar
https://senegal-streets.openalfa.com/thies