Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): Add Street to location fr_SN #2536

Merged
merged 13 commits into from
Nov 14, 2023

Conversation

makhtar-sarr
Copy link
Contributor

This PR adds the most famous streets in the Dakar and Thiès region. As it's an exhaustive list, I've only included a few, although others may be added in future PRs.

https://senegal-streets.openalfa.com/dakar
https://senegal-streets.openalfa.com/thies

@makhtar-sarr makhtar-sarr requested a review from a team as a code owner November 10, 2023 12:38
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #2536 (8a906a5) into next (652da4f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2536   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files        2801     2806    +5     
  Lines      249910   249971   +61     
  Branches     1083     1084    +1     
=======================================
+ Hits       248863   248932   +69     
+ Misses       1019     1011    -8     
  Partials       28       28           
Files Coverage Δ
src/locales/fr_SN/location/index.ts 100.00% <100.00%> (ø)
src/locales/fr_SN/location/secondary_address.ts 100.00% <100.00%> (ø)
src/locales/fr_SN/location/street_address.ts 100.00% <100.00%> (ø)
src/locales/fr_SN/location/street_pattern.ts 100.00% <100.00%> (ø)
src/locales/fr_SN/location/street_prefix.ts 100.00% <100.00%> (ø)
src/locales/fr_SN/location/street_suffix.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT added s: on hold Blocked by something or frozen to avoid conflicts p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels Nov 10, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Nov 10, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Nov 10, 2023

@ST-DDT ST-DDT added needs rebase There is a merge conflict and removed s: on hold Blocked by something or frozen to avoid conflicts labels Nov 11, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Nov 11, 2023

This is no longer blocked, but there appears to be a merge conflict.

@makhtar-sarr
Copy link
Contributor Author

Sorry, I think I've solved it.

@ST-DDT ST-DDT removed the needs rebase There is a merge conflict label Nov 11, 2023
@ST-DDT ST-DDT merged commit 36fc517 into faker-js:next Nov 14, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants