Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: check mergable by label #2405

Merged
merged 12 commits into from
Sep 20, 2023
Merged

ci: check mergable by label #2405

merged 12 commits into from
Sep 20, 2023

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Sep 18, 2023 •
edited
Loading

This ci blocks PRs by the labels on hold and do not merge yet, so it cannot accidentally be merged by not reading the labels

Code is slightly copied from https://stackoverflow.com/questions/71502652/prevent-merging-of-branch-conditionally-based-on-label

@Shinigami92 Shinigami92 added the c: infra Changes to our infrastructure or project setup label Sep 18, 2023
@Shinigami92 Shinigami92 self-assigned this Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023 •
edited
Loading

Codecov Report

Merging #2405 (777c0b6) into next (fd6557e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2405   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files        2801     2801           
  Lines      252469   252469           
  Branches     1104     1104           
=======================================
  Hits       251496   251496           
  Misses        946      946           
  Partials       27       27

see 2 files with indirect coverage changes

@ST-DDT ST-DDT added this to the vAnytime milestone Sep 18, 2023
@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Sep 18, 2023
@Shinigami92 Shinigami92 added the s: on hold Blocked by something or frozen to avoid conflicts label Sep 18, 2023
@Shinigami92
Copy link
Member Author

Shinigami92 commented Sep 18, 2023 •
edited
Loading

"s: on hold" does not work correctly ❌

@Shinigami92 Shinigami92 added the do NOT merge yet Do not merge this PR into the target branch yet label Sep 18, 2023
@Shinigami92
Copy link
Member Author

do not merge yet works correctly ✅

@Shinigami92 Shinigami92 removed s: on hold Blocked by something or frozen to avoid conflicts do NOT merge yet Do not merge this PR into the target branch yet labels Sep 18, 2023
@Shinigami92
Copy link
Member Author

Need to work on this later, I have meetings 👋

@Shinigami92 Shinigami92 added do NOT merge yet Do not merge this PR into the target branch yet s: on hold Blocked by something or frozen to avoid conflicts and removed do NOT merge yet Do not merge this PR into the target branch yet labels Sep 18, 2023
@Shinigami92 Shinigami92 added the do NOT merge yet Do not merge this PR into the target branch yet label Sep 18, 2023
@Shinigami92 Shinigami92 removed do NOT merge yet Do not merge this PR into the target branch yet s: on hold Blocked by something or frozen to avoid conflicts labels Sep 18, 2023
@Shinigami92 Shinigami92 added the s: on hold Blocked by something or frozen to avoid conflicts label Sep 18, 2023
@Shinigami92 Shinigami92 added do NOT merge yet Do not merge this PR into the target branch yet and removed s: on hold Blocked by something or frozen to avoid conflicts do NOT merge yet Do not merge this PR into the target branch yet labels Sep 18, 2023
@Shinigami92
Copy link
Member Author

Current solution is based on https://chat.openai.com/share/8cb16814-2855-4fbd-87e5-bde8ba349728

Now it seems to work

@Shinigami92 Shinigami92 marked this pull request as ready for review September 18, 2023 11:49
@Shinigami92 Shinigami92 requested a review from a team as a code owner September 18, 2023 11:49
ST-DDT
ST-DDT reviewed Sep 18, 2023
View reviewed changes
.github/workflows/check-mergable-by-label.yml Outdated Show resolved Hide resolved
.github/workflows/check-mergable-by-label.yml Outdated Show resolved Hide resolved
.github/workflows/check-mergable-by-label.yml Outdated Show resolved Hide resolved
.github/workflows/check-mergable-by-label.yml Outdated Show resolved Hide resolved
.github/workflows/check-mergable-by-label.yml Show resolved Hide resolved
@Shinigami92 Shinigami92 marked this pull request as draft September 19, 2023 13:23
@Shinigami92 Shinigami92 added s: on hold Blocked by something or frozen to avoid conflicts and removed s: on hold Blocked by something or frozen to avoid conflicts labels Sep 19, 2023
@Shinigami92 Shinigami92 marked this pull request as ready for review September 19, 2023 13:44
@Shinigami92 Shinigami92 requested review from ST-DDT and a team September 19, 2023 13:46
@ST-DDT ST-DDT requested a review from a team September 19, 2023 14:06
@Shinigami92 Shinigami92 merged commit da423b6 into next Sep 20, 2023
20 checks passed
@Shinigami92 Shinigami92 deleted the check-mergable-by-label branch September 20, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@prisis prisis prisis approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.
4 participants
@Shinigami92 @ST-DDT @prisis @xDivisionByZerox