Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(image): explain deprecation of category methods #2040

Merged
merged 6 commits into from
Apr 17, 2023

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Apr 12, 2023

fix #2019

Not sure if an explanation is required next to the @see as well as in the deprecation section?

image

@matthewmayer matthewmayer requested a review from a team as a code owner April 12, 2023 14:57
@matthewmayer matthewmayer self-assigned this Apr 12, 2023
@matthewmayer matthewmayer added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent m: image Something is referring to the image module labels Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #2040 (20bdd19) into next (62b1aed) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 20bdd19 differs from pull request most recent head 0e82c40. Consider uploading reports for the commit 0e82c40 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2040      +/-   ##
==========================================
- Coverage   99.61%   99.60%   -0.02%     
==========================================
  Files        2535     2535              
  Lines      241607   241641      +34     
  Branches     1281     1276       -5     
==========================================
+ Hits       240678   240683       +5     
- Misses        902      931      +29     
  Partials       27       27              
Impacted Files Coverage Δ
src/modules/image/index.ts 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the runtime warning messages in the proposed properties as well.
Otherwise looks good.

src/modules/image/index.ts Outdated Show resolved Hide resolved
src/modules/image/index.ts Outdated Show resolved Hide resolved
src/modules/image/index.ts Outdated Show resolved Hide resolved
src/modules/image/index.ts Outdated Show resolved Hide resolved
src/modules/image/index.ts Outdated Show resolved Hide resolved
src/modules/image/index.ts Outdated Show resolved Hide resolved
src/modules/image/index.ts Outdated Show resolved Hide resolved
src/modules/image/index.ts Outdated Show resolved Hide resolved
src/modules/image/index.ts Outdated Show resolved Hide resolved
src/modules/image/index.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested review from a team and Shinigami92 April 16, 2023 14:09
@ST-DDT ST-DDT enabled auto-merge (squash) April 17, 2023 08:21
@ST-DDT ST-DDT merged commit 4708011 into faker-js:next Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation m: image Something is referring to the image module p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Improve deprecation message for faker.image.abstract() etc
4 participants