Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(helpers): document unique deprecation #2001

Merged
merged 5 commits into from
Apr 4, 2023
Merged

Conversation

Shinigami92
Copy link
Member

the docs part for #1785

@Shinigami92 Shinigami92 added the c: docs Improvements or additions to documentation label Apr 1, 2023
@Shinigami92 Shinigami92 added this to the v8.0 - Module Re-Shuffling milestone Apr 1, 2023
@Shinigami92 Shinigami92 self-assigned this Apr 1, 2023
@Shinigami92 Shinigami92 requested a review from a team April 1, 2023 12:43
@Shinigami92 Shinigami92 requested a review from a team as a code owner April 1, 2023 12:43
@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #2001 (fb6273a) into next (cddbb95) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2001   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files        2562     2562           
  Lines      243236   243236           
  Branches     1279     1279           
=======================================
+ Hits       242316   242322    +6     
+ Misses        894      888    -6     
  Partials       26       26           

see 1 file with indirect coverage changes

@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Apr 1, 2023
ST-DDT
ST-DDT previously approved these changes Apr 1, 2023
@ST-DDT ST-DDT requested review from a team April 1, 2023 12:59
ST-DDT
ST-DDT previously approved these changes Apr 1, 2023
@ST-DDT ST-DDT requested a review from a team April 1, 2023 14:04
@ST-DDT ST-DDT requested a review from a team April 2, 2023 21:08
@ST-DDT ST-DDT added the needs rebase There is a merge conflict label Apr 3, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Apr 3, 2023

Looks we got a merge conflict here.

@Shinigami92 Shinigami92 dismissed stale reviews from xDivisionByZerox and ST-DDT via 76b1a45 April 3, 2023 18:28
@Shinigami92 Shinigami92 removed the needs rebase There is a merge conflict label Apr 3, 2023
@ST-DDT ST-DDT requested a review from a team April 3, 2023 18:31
@ST-DDT ST-DDT requested a review from a team April 4, 2023 07:27
@ST-DDT ST-DDT merged commit ea62046 into next Apr 4, 2023
@ST-DDT ST-DDT deleted the docs-unique-deprecation branch April 4, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants