-
-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: separate jsdoc tag tests #1969
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
commented
Mar 23, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1969 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 2460 2460
Lines 240146 240146
Branches 1277 1278 +1
=======================================
+ Hits 239234 239251 +17
+ Misses 889 872 -17
Partials 23 23 |
Right now the loop should be swapped yet it is: it should be one of:
|
ST-DDT
reviewed
Mar 23, 2023
ST-DDT
reviewed
Mar 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a beforeAll(deleteTemp);
ST-DDT
previously approved these changes
Mar 23, 2023
matthewmayer
previously approved these changes
Mar 28, 2023
Co-authored-by: ST-DDT <[email protected]>
ST-DDT
previously approved these changes
Mar 28, 2023
ST-DDT
requested changes
Mar 28, 2023
ST-DDT
approved these changes
Mar 29, 2023
xDivisionByZerox
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the history we had some (mostly newbie) contributors but also myself that got confused by the
examplesAndDeprecations
test.This PR aims for separating the verification of each JSDoc tag into its own section, so it can faster be identified which problem occurred.
Also this improves the test in that way that for example when a
@param
fails, a@since
tag will still get validated in the same test run.