Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: keyboard only search navigation #1932

Merged
merged 7 commits into from
Mar 20, 2023
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 14, 2023

Allow navigating in the api search by pressing Enter.

screen-recorder-tue-mar-14-2023-22-31-26.webm

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision labels Mar 14, 2023
@ST-DDT ST-DDT requested review from a team March 14, 2023 21:34
@ST-DDT ST-DDT self-assigned this Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #1932 (86a5453) into next (5dc2fa8) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1932      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.01%     
==========================================
  Files        2354     2354              
  Lines      236555   236555              
  Branches     1231     1226       -5     
==========================================
- Hits       235690   235678      -12     
- Misses        843      855      +12     
  Partials       22       22              

see 2 files with indirect coverage changes

@ST-DDT
Copy link
Member Author

ST-DDT commented Mar 16, 2023

Team Decision

We want this.

@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Mar 16, 2023
@ST-DDT ST-DDT removed the s: needs decision Needs team/maintainer decision label Mar 16, 2023
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My approval is needed, because one other maintainer need to approve

@ST-DDT ST-DDT enabled auto-merge (squash) March 20, 2023 18:47
@ST-DDT ST-DDT merged commit 93e1433 into next Mar 20, 2023
@ST-DDT ST-DDT deleted the docs/keyboard-search-navigation branch March 20, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants