Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use native mastodon icon #1729

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Jan 10, 2023

Since 1.0.0-alpha.34 in vitepress you can provide 'mastodon' as a social link option, instead of providing the icon yourself.

@Shinigami92 Shinigami92 added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Jan 10, 2023
@Shinigami92 Shinigami92 self-assigned this Jan 10, 2023
@Shinigami92 Shinigami92 requested a review from a team January 10, 2023 21:03
@Shinigami92 Shinigami92 requested a review from a team as a code owner January 10, 2023 21:03
@Shinigami92 Shinigami92 requested a review from a team January 10, 2023 21:03
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #1729 (16e1afa) into next (c2635f1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1729   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2336     2336           
  Lines      241146   241146           
  Branches     1102     1102           
=======================================
  Hits       240262   240262           
  Misses        863      863           
  Partials       21       21           

Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the description to give further information why this works now.

@Shinigami92 Shinigami92 merged commit f4615e1 into next Jan 11, 2023
@Shinigami92 Shinigami92 deleted the docs-use-mastodon-native-icon branch January 11, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants