Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(locale): mk (Macedonian) names should use cyrillic а #1557

Merged
merged 3 commits into from
Nov 16, 2022
Merged

fix(locale): mk (Macedonian) names should use cyrillic а #1557

merged 3 commits into from
Nov 16, 2022

Conversation

matthewmayer
Copy link
Contributor

fix #1556

@matthewmayer matthewmayer requested a review from a team as a code owner November 13, 2022 16:36
@codecov
Copy link

codecov bot commented Nov 13, 2022 •
edited
Loading

Codecov Report

Merging #1557 (5fc8a18) into next (801e9e0) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1557   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2214     2214           
  Lines      238816   238812    -4     
  Branches     1029     1029           
=======================================
- Hits       237954   237950    -4     
  Misses        841      841           
  Partials       21       21
Impacted Files Coverage Δ
src/locales/mk/person/female_first_name.ts 100.00% <100.00%> (ø)
src/locales/mk/person/female_last_name.ts 100.00% <100.00%> (ø)
src/locales/mk/person/male_first_name.ts 100.00% <100.00%> (ø)

@import-brain import-brain added c: bug Something isn't working c: locale Permutes locale definitions p: 1-normal Nothing urgent m: person Something is referring to the person module labels Nov 13, 2022
@import-brain import-brain requested a review from a team November 13, 2022 18:00
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Nov 15, 2022
@ST-DDT ST-DDT requested review from a team November 15, 2022 23:40
@Shinigami92 Shinigami92 changed the title fix(locale): mk (Macedonian) names should use all Cyrillic chars not Latin fix(locale): mk (Macedonian) names should use cyrillic а Nov 16, 2022
@Shinigami92 Shinigami92 merged commit 1796559 into faker-js:next Nov 16, 2022
This was referenced Mar 14, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@import-brain import-brain import-brain approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@matthewmayer matthewmayer

Labels
c: bug Something isn't working c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

Some Macedonian names use latin a instead of Cyrillic а
4 participants
@matthewmayer @ST-DDT @Shinigami92 @import-brain