Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): remove API in guide section #1402

Merged
merged 2 commits into from
Oct 1, 2022
Merged

Conversation

xDivisionByZerox
Copy link
Member

This PR removes the API section on the Guide page.

Fixes #1326

@xDivisionByZerox xDivisionByZerox added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Sep 29, 2022
@xDivisionByZerox xDivisionByZerox added this to the v7 - Current Major milestone Sep 29, 2022
@xDivisionByZerox xDivisionByZerox requested review from a team September 29, 2022 17:52
@xDivisionByZerox xDivisionByZerox self-assigned this Sep 29, 2022
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner September 29, 2022 17:52
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #1402 (9c30520) into main (9949861) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 9c30520 differs from pull request most recent head 5b35a9c. Consider uploading reports for the commit 5b35a9c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1402      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.01%     
==========================================
  Files        2165     2165              
  Lines      241432   241432              
  Branches     1021     1017       -4     
==========================================
- Hits       240549   240525      -24     
- Misses        862      886      +24     
  Partials       21       21              
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 81.74% <0.00%> (-6.35%) ⬇️

@ST-DDT ST-DDT requested review from a team September 29, 2022 21:26
@ST-DDT ST-DDT enabled auto-merge (squash) October 1, 2022 07:19
@ST-DDT ST-DDT merged commit 5b90bfb into main Oct 1, 2022
@Shinigami92 Shinigami92 deleted the docs/remove-api-from-guide branch October 12, 2022 12:11
wael-fadlallah pushed a commit to wael-fadlallah/faker that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove API navigation from the Guide page
4 participants