Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🇫🇷 fr and 🇨🇭 fr_CH 🎨 colors #1007

Merged
merged 1 commit into from
May 26, 2022
Merged

Conversation

Yago
Copy link
Contributor

@Yago Yago commented May 26, 2022

The new color module was not supporting the newly created fr and fr_CH colors

@Yago Yago requested a review from a team as a code owner May 26, 2022 12:12
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #1007 (990ee68) into main (b50fb6d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1007   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files        2113     2115    +2     
  Lines      227001   227025   +24     
  Branches      982      982           
=======================================
+ Hits       226253   226277   +24     
  Misses        728      728           
  Partials       20       20           
Impacted Files Coverage Δ
src/locales/fr/commerce/index.ts 100.00% <ø> (ø)
src/locales/fr_CH/commerce/index.ts 100.00% <ø> (ø)
src/locales/en/music/index.ts 100.00% <100.00%> (ø)
src/locales/fr/color/human.ts 100.00% <100.00%> (ø)
src/locales/fr/color/index.ts 100.00% <100.00%> (ø)
src/locales/fr/index.ts 100.00% <100.00%> (ø)
src/locales/fr_CH/color/human.ts 100.00% <100.00%> (ø)
src/locales/fr_CH/color/index.ts 100.00% <100.00%> (ø)
src/locales/fr_CH/index.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: locale Permutes locale definitions labels May 26, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone May 26, 2022
@ST-DDT ST-DDT requested review from a team May 26, 2022 12:20
@Shinigami92 Shinigami92 merged commit d96457e into faker-js:main May 26, 2022
Minozzzi pushed a commit to Minozzzi/faker that referenced this pull request Jul 19, 2022
@xDivisionByZerox xDivisionByZerox added the m: color Something is referring to the color module label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: color Something is referring to the color module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants