Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename userName to username #3023

Closed
glen-84 opened this issue Jul 21, 2024 · 3 comments · Fixed by #3130
Closed

Rename userName to username #3023

glen-84 opened this issue Jul 21, 2024 · 3 comments · Fixed by #3130
Assignees
@suyashgulati
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs deprecation A deprecation was made in the PR good first issue Good for newcomers m: internet Something is referring to the internet module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
vAnytime

Comments

@glen-84
Copy link

glen-84 commented Jul 21, 2024 •
edited by xDivisionByZerox
Loading

The userName method in the internet module should be named username – consider deprecating the former.

https://english.stackexchange.com/questions/43436/username-user-name-or-user-name
@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: internet Something is referring to the internet module deprecation A deprecation was made in the PR labels Jul 21, 2024
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Jul 21, 2024
@xDivisionByZerox xDivisionByZerox added the s: needs decision Needs team/maintainer decision label Jul 22, 2024
@ST-DDT
Copy link
Member

ST-DDT commented Sep 19, 2024

Team Decision

We will rename the faker.internet.userName() method to faker.internet.username().
Contributions welcome.

@ST-DDT ST-DDT added good first issue Good for newcomers s: accepted Accepted feature / Confirmed bug and removed s: needs decision Needs team/maintainer decision labels Sep 19, 2024
@Shinigami92
Copy link
Member

@glen-84 If you would like, you can contribute a PR

@suyashgulati
Copy link
Contributor

Can you please assign to me? @Shinigami92

@suyashgulati suyashgulati mentioned this issue Sep 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suyashgulati suyashgulati

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs deprecation A deprecation was made in the PR good first issue Good for newcomers m: internet Something is referring to the internet module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
vAnytime
Development

Successfully merging a pull request may close this issue.

refactor(internet): rename userName method to username suyashgulati/faker
5 participants
@glen-84 @ST-DDT @Shinigami92 @suyashgulati @xDivisionByZerox