Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether the system commonFileName (SK) test is still useful #1885

Closed
ST-DDT opened this issue Feb 28, 2023 · 1 comment · Fixed by #3206
Closed

Check whether the system commonFileName (SK) test is still useful #1885

ST-DDT opened this issue Feb 28, 2023 · 1 comment · Fixed by #3206
Assignees
Labels
Milestone

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Feb 28, 2023

faker/test/system.spec.ts

Lines 429 to 434 in 956a15f

it('#770', () => {
faker.seed(5423027051750305);
faker.setLocale('sk');
faker.system.commonFileName('xml');
faker.system.commonFileName('xml');
});

This test might have gone obsolete by updating (#808) / filtering the mime-types (#1788).

Created on behalf of @Shinigami92 in #1735 (comment)

@ST-DDT
Copy link
Member Author

ST-DDT commented Sep 21, 2023

The test now resides here:

describe('extra tests', () => {
describe('commonFileName()', () => {
it('#770', () => {
fakerSK.seed(5423027051750305);
fakerSK.system.commonFileName('xml');
fakerSK.system.commonFileName('xml');
});
});
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

1 participant