Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on noImplicitThis in tsconfig #1838

Closed
ST-DDT opened this issue Feb 13, 2023 · 2 comments · Fixed by #1842
Closed

Turn on noImplicitThis in tsconfig #1838

ST-DDT opened this issue Feb 13, 2023 · 2 comments · Fixed by #1842
Assignees
@ST-DDT
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Milestone
v8.x

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Feb 13, 2023 •
edited
Loading

#651 partially activated strict mode, this flag was omitted at that time and should probably be turned on.

faker/tsconfig.json

Line 16 in c46c539

// "noImplicitThis": true,

Related issues:
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Feb 13, 2023
@ST-DDT ST-DDT moved this to Todo in Faker Roadmap Feb 13, 2023
This was referenced Feb 13, 2023
Merged
Closed
Closed
Closed
Closed
@Shinigami92
Copy link
Member

Shinigami92 commented Feb 14, 2023 •
edited
Loading

I tried to set noImplicitThis: true but I have a problem in line

faker/src/modules/helpers/unique.ts

Line 140 in c46c539

const result: ReturnType<Method> = method.apply(this, args);

But as we want to get rid of this anyway

I will put no more effort into noImplicitThis until then

@ST-DDT ST-DDT mentioned this issue Feb 14, 2023
Merged
@ST-DDT ST-DDT linked a pull request Feb 14, 2023 that will close this issue
chore: turn on noImplicitThis #1842
Merged
@ST-DDT
Copy link
Member Author

ST-DDT commented Feb 14, 2023

Fixed via: #1842

@ST-DDT ST-DDT self-assigned this Feb 14, 2023
@ST-DDT ST-DDT moved this from Todo to In Progress in Faker Roadmap Feb 14, 2023
@ST-DDT ST-DDT moved this from In Progress to Awaiting Review in Faker Roadmap Feb 14, 2023
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Faker Roadmap Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ST-DDT ST-DDT

Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging a pull request may close this issue.

chore: turn on noImplicitThis faker-js/faker
2 participants
@ST-DDT @Shinigami92