Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Macedonian names use latin a instead of Cyrillic а #1556

Closed
9 of 10 tasks
matthewmayer opened this issue Nov 13, 2022 · 0 comments · Fixed by #1557
Closed
9 of 10 tasks

Some Macedonian names use latin a instead of Cyrillic а #1556

matthewmayer opened this issue Nov 13, 2022 · 0 comments · Fixed by #1557
Assignees
Labels
c: bug Something isn't working c: locale Permutes locale definitions m: person Something is referring to the person module s: accepted Accepted feature / Confirmed bug
Milestone

Comments

@matthewmayer
Copy link
Contributor

matthewmayer commented Nov 13, 2022

Pre-Checks

Describe the bug

Many of the Macedonian female names like Белчевa end in a Latin a, not a Cyrillic а

Although this seems like a minor issue it causes unexpected results from slugify

> faker.helpers.slugify('Белчевa')
'a'

which in turn leads to weird email addresses being generated

Minimal reproduction code

Find names with non-Cyrillic chars:

faker.locales.mk.person.female_last_name.filter(name=>!/^[\u0400-\u04FF]+$/.test(name))

Additional Context

No response

Environment Info

System:
    OS: macOS 12.6
    CPU: (8) x64 Apple M1
    Memory: 37.71 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 14.20.0 - /usr/local/bin/node
    npm: 8.19.1 - /usr/local/bin/npm
  Browsers:
    Chrome: 107.0.5304.110
    Firefox: 98.0
    Safari: 16.0

Which module system do you use?

  • CJS
  • ESM

Used Package Manager

npm

@matthewmayer matthewmayer added c: bug Something isn't working s: pending triage Pending Triage labels Nov 13, 2022
@import-brain import-brain removed the s: pending triage Pending Triage label Nov 13, 2022
@import-brain import-brain moved this to Awaiting Review in Faker Roadmap Nov 13, 2022
@import-brain import-brain added c: locale Permutes locale definitions m: person Something is referring to the person module labels Nov 13, 2022
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Nov 15, 2022
Repository owner moved this from Awaiting Review to Done in Faker Roadmap Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working c: locale Permutes locale definitions m: person Something is referring to the person module s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants