Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DESTDIR and NAME reintroduction #605

Closed
s7effeno opened this issue May 12, 2024 · 4 comments · Fixed by #606
Closed

DESTDIR and NAME reintroduction #605

s7effeno opened this issue May 12, 2024 · 4 comments · Fixed by #606

Comments

@s7effeno
Copy link

Would it make sense for this project to bring back DESTDIR and NAME to build.zig from the old makefile? Take a look at this

@AnErrupTion
Copy link
Collaborator

Ah yes, that's absolutely worth bringing back. I completely forgot this existed, to be honest 😅. I'll see what I can do probably next weekend.

Oh and by the way, the version for ly-git needs to be updated, since Ly is now tracking version 1.0.0 and not 0.6.0.

@s7effeno
Copy link
Author

Thanks, would you consider tagging the point regarding the updated version?

@AnErrupTion
Copy link
Collaborator

What do you mean exactly by that? I plan on fixing a few more bugs at least before shipping 1.0.0.

@s7effeno
Copy link
Author

The version will automatically be updated after the new release then, you can see how pkgver() gets it. It's actually not recommended for me to manually edit for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants