-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Decimation/Interpolation to node class. #141
Conversation
Pull Request ReviewHey there! 👋 I've summarized the results of the previous tasks for you. Let's get started with the review! Changes
Suggestions
Bugs
Improvements
RatingOverall code rating: 8/10 Criteria:
That's it for the review! Let me know if you need any further assistance. Good luck with your pull request! 🚀 |
* A special tag PerformDecimationInterpolation is required for node be enable decimation/interpolation. * Add ports_status to simplify port limits checks. * Add qa_node.cpp for unit tests of node class.
…r, denominator, stride.
SonarCloud Quality Gate failed. 0 Bugs 62.4% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Force merging due to coverage requirements. We'll probably have to add some rules to make it possible to actually reach the coverage goal, there are e.g. some fmt constructs that generate branches that are not easily reachable. |
PerformDecimationInterpolation
is required for node be enable decimation/interpolation.ports_status
to simplify port limits checks.qa_node.cpp
for unit tests ofnode
class.New
main