Performance issues due to ToolbarLayout

[Maradox]

Today I discovered performance issues regarding the library (bad scrolling-performance in lists, ripple highlighting freezes etc).

Without the FABToolbar the issues are gone. I digged deeper and discovered that if I remove only the toolbarLayout from my View-Hierarchy it works as well.

Thus I guess it has to do with toolbarLayout.getViewTreeObserver().addOnGlobalLayoutListener which is never removed.

[fafaldo-zz]

Hmm, that ViewTreeObserver was introduced to listen to toolbar's height changes so I can't just remove it. But I suppose it really is called too frequently. Can you try importing the lib as module and moving that piece of code inside
toolbarLayout.addOnLayoutChangeListener(new OnLayoutChangeListener() { @Override public void onLayoutChange(View v, int left, int top, int right, int bottom, int oldLeft, int oldTop, int oldRight, int oldBottom) { if(top != oldTop || bottom != oldBottom) { <listener code here...> } } }

If that solves your performance issues I will apply that as a new solution in the code.

[Maradox]

It works.
But note that in the case onLayout is called multiple times, several OnLayoutChangeListener are registered and never unregistered.

[fafaldo-zz]

Initialization process is done only once:
if(!isInit) { return; }
So the listener should be registered only once ;)

[Maradox]

Oh sorry, overlooked that one.

[Maradox]

Do you have an ETA when this fix will be deployed?

[fafaldo-zz]

I'm sorry, I am really busy at work recently. I will do it by 11.03 (Friday).

[Maradox]

No problem. I added a pull-request for the changes.