Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some targets are missing from the results after running the Run() command sometimes. #14

Closed
fadhilyori opened this issue Jul 3, 2023 · 1 comment · Fixed by #19
Closed
Labels
bug Something isn't working

Comments

@fadhilyori
Copy link
Owner

fadhilyori commented Jul 3, 2023

Describe the bug:
Some targets are missing from the results after running the Run() command sometimes.

To Reproduce:
Steps to reproduce the behavior:

  1. Modify main.go to print the length of s.Results and s.Targets.
  2. Run the command using large hosts, for example, /16 or /24, and use high concurrency (256).
  3. The length of s.Results sometimes does not match the length of s.Targets. If we print the map, we can observe that some IP addresses are not present.

Expected behavior:
The length of s.Results should be the same as the length of s.Targets.

Screenshots:
The IP address 127.0.0.3 is not present in s.Results.
image

Additional context
This issue arises due to unsynchronized data stores among goroutines.

@fadhilyori fadhilyori added the bug Something isn't working label Jul 3, 2023
@izzatbey
Copy link
Contributor

izzatbey commented Jul 4, 2023

i've got same issue here as you said above as shown below :
image

and i've come out with the solution about this, i'll create the pull request of the solution for you
image

@fadhilyori fadhilyori linked a pull request Jul 4, 2023 that will close this issue
@fadhilyori fadhilyori added this to the Version 1.0.0 Release milestone Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants