studio: show a message or error component when there are no claimants #669 #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishpaul777
changed the title
Deploying dega-docs with
|
| Latest commit: |
8fe848a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a3722d3a.dega-docs.pages.dev |
| Branch Preview URL: | https://fix-669.dega-docs.pages.dev |
surajmn1
reviewed
May 22, 2024
studio/src/pages/claims/index.js
Outdated
| @@ -86,6 +116,8 @@ function Claims({ permission }) { | |||
| return { claims: [], total: 0, loading: state.claims.loading }; | |||
| }); | |||
|
|
|||
| console.log(ratingsCount, loading) | |||
surajmn1
reviewed
May 22, 2024
| } | ||
| />) | ||
| } | ||
|
|
There was a problem hiding this comment.
@ishpaul777 can the case when both ratings and claimants aren't present be handled?
There was a problem hiding this comment.
you mean showing both at same time ?
There was a problem hiding this comment.
we can refactor this to have create rating and create claimants button inside and then conditionally render both or one.
surajmn1
previously approved these changes
May 23, 2024
surajmn1
previously approved these changes
Jun 10, 2024
ishpaul777
dismissed
surajmn1’s stale review
The merge-base changed after approval.
surajmn1
previously approved these changes
Jun 10, 2024
ishpaul777
dismissed
surajmn1’s stale review
The merge-base changed after approval.
surajmn1
changed the title
surajmn1
approved these changes
Jun 10, 2024
|
@shreeharsha-factly please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#669