Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ULog float information printing broken #939

Closed
declancm opened this issue Feb 24, 2024 · 6 comments
Closed

ULog float information printing broken #939

declancm opened this issue Feb 24, 2024 · 6 comments

Comments

@declancm
Copy link
Contributor

Problem description

ULog information messages of type float don't print correctly in the Info tab. They all display the same huge value. I have to use Pyulog to view the float information messages

image

Answer these questions (or I will ignore your issue)

  1. Describe your platform / Operative System and the version of PlotJuggler you are using.
    Windows 11
  2. Compile and try the latest version in the main branch and check if the problem persists.
    Tested on 3.9.0 and read the release notes after - haven't been able to build master successfully.
  3. Check if the problem can be reproduced using the dummy data created by the command line argument "-t" or one of the files in the folder "datasamples".
    There are no ULog files in the datasamples.
  4. If it can't be reproduced with the dummy data, please share the CSV file or the rosbag that can be used to reproduce the problem.
    Can't attach ULog files.
@facontidavide
Copy link
Owner

Please provide a sample file to reproduce the issue

@declancm
Copy link
Contributor Author

@declancm
Copy link
Contributor Author

declancm commented Mar 6, 2024

I'll work on a fix

@declancm
Copy link
Contributor Author

declancm commented Mar 6, 2024

I've found the issue - the info values for most info message types are getting cast from the key strings instead of the value. I'll submit a pull request ASAP. This is a screenshot from the working info message:

image

@facontidavide
Copy link
Owner

oh, thanks for finding this!

@declancm
Copy link
Contributor Author

declancm commented Mar 6, 2024

You're welcome!

@declancm declancm closed this as completed Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants