Support Protos That Reference Google/Protobuf #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installed plotjuggler via snap in ubuntu 20.04
Noticed that, when importing a large protobuf message which depends on google/protobuf, I got the following error
I assumed this was just a problem of needing to reference the path to these protos. However, this path selection through the plotjuggler GUI was unsuccessful.
Google'd the problem and found this discussion which yielded the result of installing apt package
libprotobuf-dev. Once this was installed, I did not need to add anything to my protobuf path to get the import to work.I should probably dig deeper to figure out why this package was needed instead of just
libprotobuf17, but figured the solution might be valuable before that detail is solved.