From 721be841590eb7e0a2d0ff76701310bb9d1946a9 Mon Sep 17 00:00:00 2001 From: Michael Orlov Date: Wed, 8 Feb 2023 10:14:15 -0800 Subject: [PATCH] Fix for segfault in DataLoadCSV destructor (#784) - Change order of deletion for dialogs. - First delete child dialog `_dateTime_dialog` then parent `_dialog`. Signed-off-by: Michael Orlov --- plotjuggler_plugins/DataLoadCSV/dataload_csv.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plotjuggler_plugins/DataLoadCSV/dataload_csv.cpp b/plotjuggler_plugins/DataLoadCSV/dataload_csv.cpp index e26581137..82c473fce 100644 --- a/plotjuggler_plugins/DataLoadCSV/dataload_csv.cpp +++ b/plotjuggler_plugins/DataLoadCSV/dataload_csv.cpp @@ -140,8 +140,8 @@ DataLoadCSV::DataLoadCSV() DataLoadCSV::~DataLoadCSV() { delete _ui; - delete _dialog; delete _dateTime_dialog; + delete _dialog; } const std::vector& DataLoadCSV::compatibleFileExtensions() const