Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Conda package #64

Open
hadim opened this issue Oct 30, 2018 · 2 comments
Open

Conda package #64

hadim opened this issue Oct 30, 2018 · 2 comments
Labels
contributions welcome help wanted Extra attention is needed

Comments

@hadim
Copy link
Contributor

hadim commented Oct 30, 2018

Following #25 (comment), a conda package would be a nice way to distribute precompiled package for Linux, Windows and Mac OSX.

For this, a conda recipe needs to be submitted as a PR to https://github.com/conda-forge/staged-recipes.

@fmassa fmassa added help wanted Extra attention is needed contributions welcome labels Oct 30, 2018
@fmassa
Copy link
Contributor

fmassa commented Oct 31, 2018

Hi @hadim ,

Thanks a lot for your help with the conda packaging.

I was giving it a second thought, and I realized that without having proper versioning of the library, it would maybe not be a good idea to have a conda package for now.
I think that having versioning in maskrcnn-benchmark is a good thing to have, but we are still moving fast and improving a few things so that a version might not be best for now.

What do you think?

@hadim
Copy link
Contributor Author

hadim commented Oct 31, 2018

The PR for the conda recipe is here: conda-forge/staged-recipes#6951

It won't be merged before the project as a Git tag with a version anyway so it's really up to you.

But even, if things will change a lot/move fast you can still make a release (just create a Git tag), so users have a reference commit to base their applications on. It's always more convenient than using a commit hash.

Versioning the lib as 0.0.1 or 0.1.0 is ok and will show users that those versions are not definitive.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contributions welcome help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants